RenJuan/TASKPM
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Bug #1473: Using OrderVersion from project in updating

Browse source 
Take advantage to remove some unneeded printStackTrace calls.

FEA: ItEr76S04BugFixing
This commit is contained in:
Manuel Rego Casasnovas 2012-07-03 09:20:51 +02:00
parent 8ff934e784
commit 2d5891c64c
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
libreplan-webapp/src/main/java/org/libreplan/ws/common/impl/OrderElementConverter.java
View file

@ -577,6 +577,7 @@ public final class OrderElementConverter {
}
}
} else { // orderElementDTO instanceof OrderLineGroupDTO
OrderVersion orderVersion = null;
if (orderElementDTO instanceof OrderDTO) {
if (!(orderElement instanceof Order)) {
throw new ValidationException(MessageFormat.format(
@ -586,7 +587,7 @@ public final class OrderElementConverter {
}
Order order = (Order) orderElement;
OrderVersion orderVersion = order.getOrderVersionFor(Registry
orderVersion = order.getOrderVersionFor(Registry
.getScenarioManager()
.getCurrent());
order.useSchedulingDataFor(orderVersion);
@ -636,8 +637,8 @@ public final class OrderElementConverter {
"Hours Group {0}: Duplicate code in DB",
childDTO.code));
}
((OrderLineGroup) orderElement).add(toEntity(childDTO,
configuration));
((OrderLineGroup) orderElement).add(toEntity(orderVersion,
childDTO, configuration));
}
}
@ -710,9 +711,8 @@ public final class OrderElementConverter {
.findByCode(orderElement.code);
return existsByCode != null;
} catch (InstanceNotFoundException e) {
e.printStackTrace();
return false;
}
return false;
}
/**
@ -739,7 +739,7 @@ public final class OrderElementConverter {
}
}
} catch (InstanceNotFoundException e) {
e.printStackTrace();
// Do nothing
}
return false;
}