ItEr41S05ValidacionEProbasFuncionaisItEr40S05 : more optimal filter in WorkReport list.

This commit is contained in:
Susana Montes Pedreira 2010-01-03 20:17:43 +01:00 committed by Javier Moran Rua
parent b6ba0b53b7
commit b2fa8ba946

View file

@ -89,6 +89,8 @@ public class WorkReportModel implements IWorkReportModel {
private static final Map<LabelType, List<Label>> mapLabelTypes = new HashMap<LabelType, List<Label>>();
private List<WorkReportDTO> listWorkReportDTOs = new ArrayList<WorkReportDTO>();
@Override
public WorkReport getWorkReport() {
return workReport;
@ -242,20 +244,19 @@ public class WorkReportModel implements IWorkReportModel {
@Transactional(readOnly = true)
public List<WorkReportDTO> getWorkReportDTOs() {
// load the work reports DTOs
List<WorkReport> listWorkReports = getAllWorkReports();
List<WorkReportDTO> resultDTOs = new ArrayList<WorkReportDTO>();
for (WorkReport workReport : listWorkReports) {
listWorkReportDTOs.clear();
for (WorkReport workReport : getAllWorkReports()) {
WorkReportDTO workReportDTO = new WorkReportDTO(workReport);
resultDTOs.add(workReportDTO);
listWorkReportDTOs.add(workReportDTO);
}
return resultDTOs;
return listWorkReportDTOs;
}
@Override
@Transactional(readOnly = true)
public List<WorkReportDTO> getFilterWorkReportDTOs(IPredicate predicate) {
List<WorkReportDTO> resultDTOs = new ArrayList<WorkReportDTO>();
for (WorkReportDTO workReportDTO : getWorkReportDTOs()) {
for (WorkReportDTO workReportDTO : listWorkReportDTOs) {
if (predicate.accepts(workReportDTO)) {
resultDTOs.add(workReportDTO);
}