Commit graph

4724 commits

Author SHA1 Message Date
Óscar González Fernández
66253cbbea Add deprecated annotation to potentially dangerous method 2010-10-01 00:53:20 +02:00
Óscar González Fernández
f419a6d38c [Bug #665] Fix bug
When allocating the hours in all a semester, only some minutes where
allocated each day. The error was that the day assigments that didn't
have at least one hour were discarded. Now only the ones with an
EffortDuration of zero are discarded.

FEA: ItEr61S05BugFixing
2010-10-01 00:52:31 +02:00
Óscar González Fernández
bf46ea2e33 Fix bug introduced in AdvancedAllocationController when changing internal types of Interval
FEA: ItEr61S08TimeUnitConfigurablePlanning
2010-10-01 00:23:18 +02:00
Óscar González Fernández
cd065cbc14 Protect against effortDuration being null.
Use always getter to protect against this possibility. The problem
must lie in a IntraDayDate created as result of a migration such that
the column for effortDuration is null. Otherwise a newly created
IntraDayDate never has a null effortDuration.

FEA: ItEr61S05BugFixing
2010-10-01 00:03:00 +02:00
Óscar González Fernández
c898f92818 Fix bug
It must call the method instead of retrieving the field

FEA: ItEr61S05BugFixing
2010-09-30 22:13:24 +02:00
Óscar González Fernández
1c0da6e7f8 Fix bug
Method was calling itself.

FEA: ItEr61S05BugFixing
2010-09-30 22:13:24 +02:00
Óscar González Fernández
7d09ed0980 Change Interval to use LocalDates and associated changes
FEA: ItEr61S08TimeUnitConfigurablePlanning
2010-09-30 22:13:24 +02:00
Óscar González Fernández
966993e10f Inherit from general case in zoom level four
Weeks do not fit into months.

FEA: ItEr61S08TimeUnitConfigurablePlanning
2010-09-30 22:13:24 +02:00
Óscar González Fernández
9723e75925 Extract subclass for typical case in which subintervals fit the parent intervals
FEA: ItEr61S08TimeUnitConfigurablePlanning
2010-09-30 22:13:23 +02:00
Óscar González Fernández
55e4c8a7c6 Pull up TimeTrackerStateUsingJodaTime to TimeTrackerState
Now all zoom levels are based on the same superclass

FEA: ItEr61S08TimeUnitConfigurablePlanning
2010-09-30 22:13:23 +02:00
Óscar González Fernández
0e8a61715f Use a less restrictive type specifying the minimun period
FEA: ItEr61S08TimeUnitConfigurablePlanning
2010-09-30 22:13:23 +02:00
Óscar González Fernández
719ce60fbf Remove getLength and setLength milliseconds from ITaskFundamentalProperties
FEA: ItEr61S08TimeUnitConfigurablePlanning
2010-09-30 22:13:23 +02:00
Óscar González Fernández
56dbc8d099 Add final constraint to field
FEA: ItEr61S08TimeUnitConfigurablePlanning
2010-09-30 22:13:23 +02:00
Óscar González Fernández
5cd724648b Remove unused constructor
FEA: ItEr61S08TimeUnitConfigurablePlanning
2010-09-30 22:13:23 +02:00
Óscar González Fernández
d8b3eed6d8 setBeginDate no longer returns the length
FEA: ItEr61S08TimeUnitConfigurablePlanning
2010-09-30 22:13:23 +02:00
Óscar González Fernández
88ee2d8231 Notify end dates events instead of length
FEA: ItEr61S08TimeUnitConfigurablePlanning
2010-09-30 22:13:23 +02:00
Óscar González Fernández
749bf03981 Add getEndDate and setEndDate to ITaskFundamentalProperties
FEA: ItEr61S08TimeUnitConfigurablePlanning
2010-09-30 22:13:23 +02:00
Óscar González Fernández
79002df918 Remove unused fields
FEA: ItEr61S08TimeUnitConfigurablePlanning
2010-09-30 22:13:23 +02:00
Diego Pino Garcia
d3ce1413ef Added report 'hours worked per worker in a month'
FEA: ItEr61S06ExceptionTypeEntity
2010-09-30 00:05:29 +02:00
Diego Pino Garcia
341145a597 Since HoursGroup extends IntegrationEntity it doesn't need its own 'code' field anymore
* Move validation unique code (Order, HoursGroup) to outer toEntity() method
* HoursGroup constructor should call IntegrationEntity.create() before
setting code, to avoid override its value
* orderWithOrderLineWithInvalidHoursGroup() expects only 1 constraint violation
as validation of code is not checked twice

FEA: ItEr61S05BugFixing
2010-09-29 17:37:17 +02:00
Óscar González Fernández
998ae94e75 Fix problem when adding extra hours at the end date of a partially completed date
If you add extra hours to a partially completed last day and you quit
the same extra hours to another day the resources per day count
changes and this is confusing for the user. The implemented solution
is to keep the same IntraDayDate end when modifying the last day.

The real solution for the underlying would be to keep an spec object
with the desired values from the user so when having to reallocate
uses the original intention of the user and not the current resources
per day and total hours values.

FEA: ItEr61S05BugFixing
2010-09-29 16:10:30 +02:00
Óscar González Fernández
7ee29c0da5 Use asExclusiveEnd mechanism
FEA: ItEr61S05BugFixing
2010-09-29 15:23:03 +02:00
Diego Pino Garcia
681c3fdc18 Fix bug validation 'OrderElement code must be unique' must be done for all OrderElements and not only for OrderLineGroups
FEA: ItEr61S07PerformanceOrderEdition
2010-09-29 12:29:57 +02:00
Diego Pino Garcia
5b0e11fb41 Add validation 'HoursGroup code must be unique' in the service layer
FEA: ItEr61S07PerformanceOrderEdition
2010-09-29 12:29:57 +02:00
Diego Pino Garcia
e76cd09bee Add new test for checking HoursGroupCode must be unique
FEA: ItEr61S07PerformanceOrderEdition
2010-09-29 12:29:57 +02:00
Diego Pino Garcia
86eb25c048 Add validation 'OrderElement code must be unique' in the service layer
FEA: ItEr61S07PerformanceOrderEdition
2010-09-29 12:29:57 +02:00
Diego Pino Garcia
1207aa9198 Move constraint validation hoursgroup.code must be unique to OrderModel.save()
HoursGroup.code must be unique for each OrderElement. This constraint
was being validation in HoursGroup, as an Hibernate validation. This
validation was very slow has for each HoursGroup it was needed to check
against all other HoursGroup. I moved this validation to
OrderModel.save() and speed up the process, keeping the same
funcionality.

FEA: ItEr61S07PerformanceOrderEdition
2010-09-29 12:29:46 +02:00
Diego Pino Garcia
23d70111e0 HoursGroup must extend from IntegrationEntity
FEA: ItEr61S05BugFixing
2010-09-29 11:16:38 +02:00
Manuel Rego Casasnovas
cc61ab72b9 [Bug #662] Removed test "orderWithLabelRepeatedInTheSameBranchIsNotAddedTwice".
The test is removed because of since commit
b446658fe2 is not possible to add the same label
twice in the same branch (this is managed with method removeLabelOnChildren that
is automatically called in addLabel).

FEA: ItEr61S05BugFixing
2010-09-28 09:56:26 +02:00
Manuel Rego Casasnovas
a9bf55a7fa [Bug #662] Improved message of check constraint in order to avoid confusions with labels code.
FEA: ItEr61S05BugFixing
2010-09-28 09:53:15 +02:00
Óscar González Fernández
e2399e1412 [Bug #664] Fix bug
The problem lay in that the child tasks would be removed but at the
same it would be saved from the task parent.

FEA: ItEr61S05BugFixing
2010-09-28 00:41:32 +02:00
Óscar González Fernández
d3892ef778 Prevent going to advance allocation when there are no allocations
FEA: ItEr61S05BugFixing
2010-09-28 00:00:27 +02:00
Óscar González Fernández
152e5216ff [Bug #663] Fix bug
It was always retrieving end data for AggregateOfResourceAllocations
and that's illegal when the aggregate is empty.

FEA: ItEr61S05BugFixing
2010-09-27 23:51:15 +02:00
Óscar González Fernández
e8b77aba32 [Bug #659] Fix bug
The problem is that the new container is newly created so it has no
task source.

FEA: ItEr61S05BugFixing
2010-09-27 20:37:53 +02:00
Diego Pino Garcia
fd6f652f54 Manage entity 'Calendar Exception Type'.
* Adds a new entry at Administration->Data Type->Exception Day Types for managing 'Calendar Exception Types'
* Adds a new field 'duration' to entity CalendarExceptionType
* Modifies Calendar managing, so when a CalendarExceptionType is selected its field duration is set to the number of hours assigned to selected CalendarExceptionType

FEA: ItEr61S06ExceptionTypeEntity
2010-09-27 18:58:07 +02:00
Óscar González Fernández
04fe46a0ab Use not recursive function so all Order children are not loaded
Order children are not loaded. This avoids query to the database.

FEA: ItEr60S17CambiosPantallaVistaEmpresa
2010-09-22 20:52:55 +02:00
Óscar González Fernández
fba968b3ab Parametrize useSchedulingDataFor so it can be specified if it's recursive
By default the behaviour is recursive so existent code is not broken.

FEA: ItEr60S17CambiosPantallaVistaEmpresa
2010-09-22 20:52:55 +02:00
Óscar González Fernández
fc475b1c34 Expose start and end as IntraDayDates in AllocationResult
FEA: ItEr60S19TimeUnitDataType
2010-09-22 18:01:56 +02:00
Óscar González Fernández
b8e7c8668a Expose start and end dates as IntraDayDates
FEA: ItEr60S19TimeUnitDataType
2010-09-22 17:53:22 +02:00
Óscar González Fernández
eec45cd955 Use method in date to get start as LocalDate
FEA: ItEr60S19TimeUnitDataType
2010-09-22 17:28:24 +02:00
Óscar González Fernández
6eefa8f605 Use IntraDayDates when merging an allocation into a Task
This way when merging the allocation the new greater precision allowed
by allocation algorithm is not lost.

FEA: ItEr60S19TimeUnitDataType
2010-09-22 17:28:24 +02:00
Óscar González Fernández
8f978bb9c7 Expose start and end dates of AggregateOfResourceAllocations as IntraDayDates
FEA: ItEr60S19TimeUnitDataType
2010-09-22 17:28:24 +02:00
Óscar González Fernández
82cae5cff7 ResourceAllocation#sortByStartDate uses the intraDayStartDate to compare the allocations
FEA: ItEr60S19TimeUnitDataType
2010-09-22 17:28:24 +02:00
Óscar González Fernández
2a645b4bca Expose start and endData of ResourceAllocation as IntraDayDate properties
FEA: ItEr60S19TimeUnitDataType
2010-09-22 17:28:24 +02:00
Óscar González Fernández
c2d0b3e1c0 Remove unused local variable
FEA: ItEr60S19TimeUnitDataType
2010-09-22 17:28:24 +02:00
Óscar González Fernández
ab6417fcf6 untilAllocating now returns a IntraDayDate
FEA: ItEr60S19TimeUnitDataType
2010-09-22 17:28:23 +02:00
Óscar González Fernández
0159438d56 Expose endDate and startDate properties of TaskElement as IntraDayDate
FEA: ItEr60S19TimeUnitDataType
2010-09-22 17:28:23 +02:00
Óscar González Fernández
9290e0390b If a day is completely filled the end date is moved to the next day
FEA: ItEr60S19TimeUnitDataType
2010-09-22 17:28:23 +02:00
Óscar González Fernández
bcde48f536 Rename TaskDate to IntraDayDate
The new name conveys better the meaning of the class

FEA: ItEr60S19TimeUnitDataType
2010-09-22 17:28:23 +02:00
Óscar González Fernández
58ae1d53ef Make methods private again
This method should not be accessible from outside of criterion

FEA: ItEr60S04ValidacionEProbasFuncionaisItEr59S04
2010-09-22 16:48:39 +02:00