Commit graph

447 commits

Author SHA1 Message Date
Óscar González Fernández
cbdcd2a62d ItEr21S04ArquitecturaServidorItEr20S04: When a criterion is saved the type must exist.
Previously the criterion type existence associated to the criterion was checked, and if not existed it was saved. Now it requires the criterion type to exist at database.
Broken tests by this change fixed.
Some refactorings were introduced at the tests to increase readability.
2009-08-12 19:31:39 +02:00
Óscar González Fernández
54603a1ed9 ItEr21S04ArquitecturaServidorItEr20S04: Fixing a spelling error. 2009-08-12 17:10:54 +02:00
Óscar González Fernández
2d58e7856d ItEr21S04ArquitecturaServidorItEr20S04: Refactoring tests of ResourceServiceTest to increase readibility. 2009-08-12 16:17:07 +02:00
Óscar González Fernández
995042633f ItEr21S04ArquitecturaServidorItEr20S04: Refactoring tests to increase readability.
Following given pattern.
2009-08-12 14:22:59 +02:00
Óscar González Fernández
0f8c692499 ItEr21S04ArquitecturaServidorItEr20S04: Adding test, "aCriterionRelatedToATransientTypeCannotBeSaved" 2009-08-12 12:55:30 +02:00
Óscar González Fernández
a5d9366397 ItEr21S04ArquitecturaServidorItEr20S04: Refactoring test so it expresses its intent in a clearer way. 2009-08-12 12:45:51 +02:00
Óscar González Fernández
2f5453923c ItEr21S04ArquitecturaServidorItEr20S04: No need to check if the criterion exists by id since the created criterions are transient instances. 2009-08-12 12:32:26 +02:00
Óscar González Fernández
e2383ad518 ItEr21S04ArquitecturaServidorItEr20S04: It's not necessary to check if the criterion type exists since was previously created at the caller method. 2009-08-12 11:56:02 +02:00
Manuel Rego Casasnovas
8d88d3da4e ItEr21S04ArquitecturaServidorItEr20S04: Removed use of CriterionService. 2009-08-12 11:49:11 +02:00
Lorenzo Tilve
449ff9cea3 ItEr21S07CUVistaRecursosTempoPorProxectoItEr20S09: New components structure and zul page for Resources Load Panel
* It has been created a new page planner/resources_use.zul with an static view of ResourcesLoadComponent entities.
   * Added ResourceLoadInterval static elements to ResourceLoad component

Signed-off-by: Óscar González Fernández <ogonzalez@igalia.com>
Removed modifications to TimeTracker
2009-08-12 11:43:01 +02:00
Óscar González Fernández
feb24373b9 ItEr21S04ArquitecturaServidorItEr20S04: Two different criterions with same name and type are detected if possible 2009-08-11 17:25:58 +02:00
Óscar González Fernández
3d1b60c1a4 ItEr21S04ArquitecturaServidorItEr20S04: Improving the name of a test. 2009-08-11 17:00:47 +02:00
Óscar González Fernández
4de1674cb0 ItEr21S04ArquitecturaServidorItEr20S04: Moving test to CriterionDAOTest and renamed to more accurate name. 2009-08-11 16:33:50 +02:00
Manuel Rego Casasnovas
f56d0c2af4 ItEr21S04ArquitecturaServidorItEr20S04: Simplifying method save at CriterionService. 2009-08-11 16:19:13 +02:00
Óscar González Fernández
5728751429 ItEr21S09CUIntroducionAvanceUnidadeTraballoItEr20S07: Removing set method, so the updatable property is read-only. 2009-08-11 15:43:23 +02:00
Óscar González Fernández
c7c410292f ItEr21S09CUIntroducionAvanceUnidadeTraballoItEr20S07: It disables edit and remove buttons if the type is immutable.
ZK cannot use nots in data binding expressions, so immutable accesor created at AdvanceType
2009-08-11 15:30:22 +02:00
Óscar González Fernández
910604f585 ItEr21S09CUIntroducionAvanceUnidadeTraballoItEr20S07: Now the model preserves the constraint: "an Advance Type cannot be updated if it's marked as not updatable" 2009-08-11 15:30:18 +02:00
Óscar González Fernández
f91f3814d1 ItEr21S09CUIntroducionAvanceUnidadeTraballoItEr20S07: Changing accessor to follow beans convention. 2009-08-11 15:24:49 +02:00
Susana Montes Pedreira
4c2dc0e2a3 ItEr21S09CUIntroducionAvanceUnidadeTraballoItEr20S07: Some changes to confirm remove window. 2009-08-11 15:24:04 +02:00
Manuel Rego Casasnovas
94cf70d61f ItEr21S04ArquitecturaServidorItEr20S04: Removed TaskElementService and its test. Moved remainder methods to OrderModel and OrderModelTest. 2009-08-11 13:15:08 +02:00
Manuel Rego Casasnovas
24839d8499 ItEr21S04ArquitecturaServidorItEr20S04: Moved test cases for basic methods from TaskElementServiceTest to TaskElementDAOTest. 2009-08-11 13:15:05 +02:00
Manuel Rego Casasnovas
c3a8edeb6d ItEr21S04ArquitecturaServidorItEr20S04: Removing basic methods of TaskElementService. 2009-08-11 13:15:01 +02:00
Óscar González Fernández
05db78783b ItEr21S09CUIntroducionAvanceUnidadeTraballoItEr20S07: Removing no longer needed comments because the tests are now clearer. 2009-08-10 21:36:33 +02:00
Óscar González Fernández
bfba19592f ItEr21S09CUIntroducionAvanceUnidadeTraballoItEr20S07: Several improvements.
Specifying the exact exception that must be thrown in the catch.
Test names improved.
Not testing all in a test. That's an anti-pattern. Just testing one thing at each test.
Simplifying the fixture. Not setting up more data than needed in order to setup test.
No need to save the order in all tests, just in one test to check it works.
2009-08-10 21:35:09 +02:00
Óscar González Fernández
218efc9ea7 ItEr21S09CUIntroducionAvanceUnidadeTraballoItEr20S07: Removing spurious catchs.
Instead of catch{fail(...)} throws clause is added. JUnit would show those exceptions and the test would fail.
2009-08-10 21:31:21 +02:00
Óscar González Fernández
2adebe96f9 ItEr21S09CUIntroducionAvanceUnidadeTraballoItEr20S07: Extracting method from repeated code. 2009-08-10 21:30:46 +02:00
Susana Montes Pedreira
c6a5636ab2 ItEr21S09CUIntroducionAvanceUnidadeTraballoItEr20S07: check the children of any orderElement no have other assignment with same advance type 2009-08-10 19:58:36 +02:00
Susana Montes Pedreira
a2c2cd0d17 ItEr21S09CUIntroducionAvanceUnidadeTraballoItEr20S07 : Move the maxValue attribute from AdvanceAssigment entity to AdvanceMeasurement entity.
Signed-off-by: Óscar González Fernández <ogonzalez@igalia.com>. Little change to commit message.
2009-08-10 19:58:12 +02:00
Óscar González Fernández
cf65db0230 ItEr20S04ArquitecturaServidorItEr19S04: Adding automatic OptimistLockingFailureException handling to WorkerCRUDController. 2009-08-10 19:50:17 +02:00
Óscar González Fernández
8f0aa042e4 ItEr20S04ArquitecturaServidorItEr19S04: Adding automatic handling of OptimistLockingFailureException. 2009-08-10 19:50:17 +02:00
Óscar González Fernández
8bfa9f2e8d ItEr21S04ArquitecturaServidorItEr20S04: Adding @Transactional. It was failing at Manage Criterions page. 2009-08-10 19:33:04 +02:00
Óscar González Fernández
b515becc1b Removing spurious tabs introduced accidentally in CriterionsBootstrap. 2009-08-10 19:21:23 +02:00
Manuel Rego Casasnovas
adc6b05879 ItEr21S04ArquitecturaServidorItEr20S04: Removed CriterionTypeService and its test. Moved methods from this test to CriterionTypeDAOTest.
Signed-off-by: Óscar González Fernández <ogonzalez@igalia.com>
Fixing the test testCannotSaveTwoDifferentCriterionTypesWithTheSameName
2009-08-10 19:05:28 +02:00
Manuel Rego Casasnovas
13f19fa1a5 ItEr21S04ArquitecturaServidorItEr20S04: Removed use of ICriterionTypeService.
Signed-off-by: Óscar González Fernández <ogonzalez@igalia.com>
Refactored some code in CriterionsBootstrap. Some catchs that did nothing now throw an exception.
2009-08-10 18:51:34 +02:00
Manuel Rego Casasnovas
50e1d83bc6 ItEr21S04ArquitecturaServidorItEr20S04: Simplifying "save" method at "CriterionTypeServiceImpl". 2009-08-10 18:25:18 +02:00
Óscar González Fernández
47271ab4ec ItEr20S07CUIntroducionAvanceUnidadeTraballoItEr19S12: Fixing property name in edition form. Now the name is unitPrecision. 2009-08-10 14:21:25 +02:00
Óscar González Fernández
934f441fe2 Substituting tabs by spaces at zul files in order to follow code conventions. 2009-08-10 12:36:28 +02:00
Óscar González Fernández
f335abe84f Substituting tabs by spaces at xml files in order to follow code conventions. 2009-08-10 12:36:28 +02:00
Óscar González Fernández
62f46c73e3 Substituting tabs by spaces at java files in order to follow code conventions. 2009-08-10 12:36:28 +02:00
Manuel Rego Casasnovas
836ff36580 ItEr20S06XestionDaComunidadeItEr19S06: Added configuration for cobertura plugin to generate coverage XML files. 2009-08-10 12:09:09 +02:00
Manuel Rego Casasnovas
0c5fcfc031 ItEr20S06XestionDaComunidadeItEr19S06: Added maven configuration for cobertura plugin. 2009-08-10 11:17:45 +02:00
Óscar González Fernández
b8271ef724 ItEr20S04ArquitecturaServidorItEr19S04: Removing sortByStartDate since by default is sorted that way. 2009-08-09 20:08:27 +02:00
Óscar González Fernández
d9aa8fa13f ItEr20S04ArquitecturaServidorItEr19S04: Removing unused methods and variables. 2009-08-09 20:03:02 +02:00
Óscar González Fernández
b0b60433cf ItEr20S04ArquitecturaServidorItEr19S04: Organizing all imports so warnings are removed. 2009-08-09 19:49:02 +02:00
Óscar González Fernández
5ee30eb5eb ItEr20S04ArquitecturaServidorItEr19S04: Erasing not used methods from Registry. They will be added as needed. 2009-08-09 19:46:31 +02:00
Óscar González Fernández
db7a75fbb0 ItEr20S04ArquitecturaServidorItEr19S04: Erasing PlannerDAORegistry since it's not used. 2009-08-09 19:46:31 +02:00
Óscar González Fernández
efaaccd102 ItEr20S04ArquitecturaServidorItEr19S04: Erasing AdvanceDAORegistry, methods moved to Registry. 2009-08-09 19:46:31 +02:00
Óscar González Fernández
fe5a957f50 ItEr20S04ArquitecturaServidorItEr19S04: Erasing remove method on Resource instance. ResourcesDAORegistry no longer needed. 2009-08-09 19:46:31 +02:00
Óscar González Fernández
078009217b ItEr20S04ArquitecturaServidorItEr19S04: Removing WorkReportsDAORegistry and creating a general Registry intended to replace all Registries. 2009-08-09 19:45:31 +02:00
Óscar González Fernández
c183170dda ItEr20S04ArquitecturaServidorItEr19S04: Copying collection properties instead of returning them directly.
This prevents modifications on the collections properties from outside of the entity.
2009-08-09 18:44:36 +02:00