Commit graph

8934 commits

Author SHA1 Message Date
Miciele Ghiorghis
f985a65a94 Tim-connector: DAO for JobSchedulerConfiguration
An implementation of IJobSchedulerConfigurationDAO
2013-02-08 11:16:16 +01:00
Miciele Ghiorghis
5418fc21b0 Tim-connector: Contract for JobSchedulerConfigurationDAO
An interface that JobSchedulerConfigurationDAO implements
2013-02-08 11:16:16 +01:00
Miciele Ghiorghis
3ba555853f Tim-connector: Contract for AppPropertiesDAO
An interface that AppPropertiesDAO implements
2013-02-08 11:16:16 +01:00
Miciele Ghiorghis
fa310807db Tim-connector: DAO for AppProperties
DAO for AppProperties. Implementation of the interface IAppPropertiesDAO
2013-02-08 11:16:16 +01:00
Manuel Rego Casasnovas
be38a3455e jira-integration: Change own implementation to strip whitespaces by StringUtils method
FEA: ItEr77S16JiraAndTimConnectorContributionIntegration
2013-02-08 10:38:33 +01:00
miciele Ghiorghis
1cad4ca9b6 Jira-integration: some improvement on get issues.
getIssues gets now the issues from jira in one request. This is done by adding a
query fields with desired fields to be included in response. Moreover the max_results
is now outside if(!query.isEmpty) statetment.
Test case is modified to read label from jira-properties instead of hard coded
2013-02-08 10:33:45 +01:00
miciele Ghiorghis
946c66163b Jira-integration: modified to test the classes instead code copied and jira label is moved to jira-conn-properties 2013-02-05 14:02:25 +01:00
Manuel Rego Casasnovas
685f0ac77d jira-integration: Allow to search labels by any chars and not only the first ones
Add simple comment explaining the purpose of SimpleListModelExt.

FEA: ItEr77S16JiraAndTimConnectorContributionIntegration
2013-02-01 11:34:34 +01:00
Manuel Rego Casasnovas
cdc140c7c8 jira-integration: Increase size of field jiraLabels
As this field could be used to store a list of labels, it's better that it's
longer than 255 chars.

FEA: ItEr77S16JiraAndTimConnectorContributionIntegration
2013-02-01 11:30:04 +01:00
Manuel Rego Casasnovas
9d17881ddb jira-integration: Fix issue in _jiraSyncInfo that was using args instead of arg
This was causing that the messages to show or not depending on the success
operation were not working properly.

Moreover, it has been updated the messages to give more information to the user.

FEA: ItEr77S16JiraAndTimConnectorContributionIntegration
2013-02-01 11:10:28 +01:00
Manuel Rego Casasnovas
21da67ffcd jira-integration: Fix minor visual stuff in JIRA part inside project edition
FEA: ItEr77S16JiraAndTimConnectorContributionIntegration
2013-02-01 10:38:28 +01:00
Manuel Rego Casasnovas
87747a1cdc jira-integration: Hide JIRA part in project edition if not activated
If JIRA is not activated the part to do the synchronization with the server in
the project edition shouldn't be visible.

FEA: ItEr77S16JiraAndTimConnectorContributionIntegration
2013-02-01 10:35:59 +01:00
Manuel Rego Casasnovas
c956b17542 jira-integration: Reload order after JIRA synchronization
This allows user to change to WBS tab and see the imported tasks just after
import the issues from JIRA.

FEA: ItEr77S16JiraAndTimConnectorContributionIntegration
2013-02-01 10:06:45 +01:00
miciele Ghiorghis
78e1d7b10b Jira-integration: classes renamed and basic comments added 2013-02-01 09:53:24 +01:00
Manuel Rego Casasnovas
25d1461263 jira-integration: Rename jiraLabelUrl to jiraLabels
Due to previous commit, this field could save a URL or a list of labels, so the
name has been changed to avoid misunderstandings.

FEA: ItEr77S16JiraAndTimConnectorContributionIntegration
2013-01-31 17:13:24 +01:00
Manuel Rego Casasnovas
5d439b032a jira-integration: Allow to store a comma-separated list of labels instead of URL
This patch allows the user to store a URL or a comma-separated list of words to
specify the possible labels for the JIRA connector.

FEA: ItEr77S16JiraAndTimConnectorContributionIntegration
2013-01-31 17:03:45 +01:00
Manuel Rego Casasnovas
f5d8984c5b jira-integration: Disable code edition in task pop-up for JIRA issues
JIRA issues code is not editable in the WBS and it shouldn't be editable in the
task edition pop-up either.

FEA: ItEr77S16JiraAndTimConnectorContributionIntegration
2013-01-31 11:00:52 +01:00
Manuel Rego Casasnovas
7a26294060 jira-integration: Avoid issue with code comming back from task edition pop-up
When you enter in the edition of a task in the WBS, if the task is a JIRA issue,
when you come back to the WBS LibrePlan was trying to update the code column,
however this column doesn't exist for JIRA issues as we're using a link.

Fixed that to avoid an exception in this situation.

FEA: ItEr77S16JiraAndTimConnectorContributionIntegration
2013-01-31 10:53:39 +01:00
Manuel Rego Casasnovas
eea2ace0cc jira-integration: Fix bug if comment length is lower than max length
If the comment length is lower than the max length of the DescriptionField, then
it's not needed to truncate it.

FEA: ItEr77S16JiraAndTimConnectorContributionIntegration
2013-01-31 10:26:20 +01:00
Manuel Rego Casasnovas
d736a512ec jira-integration: Avoid create the work report line if worker is not found
FEA: ItEr77S16JiraAndTimConnectorContributionIntegration
2013-01-31 10:12:12 +01:00
Manuel Rego Casasnovas
a3271120d7 jira-integration: Set scale for progress measurement when synchronizing order elements
FEA: ItEr77S16JiraAndTimConnectorContributionIntegration
2013-01-31 10:01:54 +01:00
Manuel Rego Casasnovas
54d17c5380 jira-integration: Only catch WebApplicationException in try for WebClient.create
FEA: ItEr77S16JiraAndTimConnectorContributionIntegration
2013-01-31 10:01:54 +01:00
Manuel Rego Casasnovas
f2709cb293 jira-integration: Surround WebClient.create calls with try/catch
In order to avoid exceptions accessing to an URL, the calls to WebClient.create
have been enclosed into try/catch statements, logging the exception and showing
an appropriate message to the user.

FEA: ItEr77S16JiraAndTimConnectorContributionIntegration
2013-01-31 08:28:06 +01:00
Manuel Rego Casasnovas
72c2d0dc1b Revert "jira-integration: Avoid saving in startSyncWithJir"
This reverts commit f3bec8193f.

Because of it was causing some issues:
* The WBS was not loaded properly after synchronization
* WorkReports cannot be saved as the order elements where not saved yet

FEA: ItEr77S16JiraAndTimConnectorContributionIntegration
2013-01-31 08:26:19 +01:00
Manuel Rego Casasnovas
4cd0afc504 jira-integration: Simplify code in updateOrCreateDescriptionValuesAndAddToWorkReportLine
As we know that the predefined WorkReportType will only have 1 DescriptionValue,
we can take advantage of this to simplify the code.

FEA: ItEr77S16JiraAndTimConnectorContributionIntegration
2013-01-30 17:43:38 +01:00
Manuel Rego Casasnovas
e16ec15add jira-integration: Move code part from updateWorkReportLine to updateOrCreateWorkReportLineAndAddToWorkReport
The code was being generated in 2 parts, first for the query and then to be set.
As in other cases if the WorkReportLine is found by code, we don't need to set
it again. So the part related to manage the code has been moved close to the
query and only set for newly created objects.

FEA: ItEr77S16JiraAndTimConnectorContributionIntegration
2013-01-30 17:39:23 +01:00
Manuel Rego Casasnovas
15bbcde0c4 jira-integration: Use new predefined work report type in JiraTimesheetSynchronizer
FEA: ItEr77S16JiraAndTimConnectorContributionIntegration
2013-01-30 17:39:23 +01:00
Manuel Rego Casasnovas
52a0e89071 jira-integration: Add predefined WorkReportType for JIRA connector
* The predefined type will have a line description value to store comments in
  each line.
* As for the case of personal timesheets the new type will be hidden for the
  users in the list of timesheets templates.

FEA: ItEr77S16JiraAndTimConnectorContributionIntegration
2013-01-30 17:13:33 +01:00
Manuel Rego Casasnovas
f3bec8193f jira-integration: Avoid saving in startSyncWithJir
User should be able to do not save if he is not happy with the result of the
JIRA importation.

FEA: ItEr77S16JiraAndTimConnectorContributionIntegration
2013-01-30 14:10:52 +01:00
Manuel Rego Casasnovas
4ebff70afa jira-integration: Remove event from syncWithJira as it's not used
FEA: ItEr77S16JiraAndTimConnectorContributionIntegration
2013-01-30 14:10:15 +01:00
Manuel Rego Casasnovas
72ada7c634 jira-integration: Disable hours edition in JIRA issues
For tasks that are JIRA issues the hours fields will be readonly.

FEA: ItEr77S16JiraAndTimConnectorContributionIntegration
2013-01-30 14:01:39 +01:00
Manuel Rego Casasnovas
2a359993ce jira-integration: Refactorization related to paint a link in the WBS if the task is a JIRA issue
* A new method isJiraIssue has been added to OrderElement checking if the code
  uses the JIRA prefix or not.
* The method Util.bind has been removed as it was specific of this link and only
  used in one place.
* To calculate issue code for the link it has been used StringUtils.removeStart.

TODO: Pending to disable hours in WBS if the task is a JIRA issue.

FEA: ItEr77S16JiraAndTimConnectorContributionIntegration
2013-01-30 13:43:40 +01:00
Manuel Rego Casasnovas
78379f56b3 jira-integration: Replace Jira by JIRA in all the strings
FEA: ItEr77S16JiraAndTimConnectorContributionIntegration
2013-01-30 12:53:42 +01:00
Manuel Rego Casasnovas
bf33fbc1ed jira-integration: Check status code against OK
FEA: ItEr77S16JiraAndTimConnectorContributionIntegration
2013-01-30 12:53:42 +01:00
Manuel Rego Casasnovas
55b5bedf81 jira-integration: Replace printStackTrace by throw RuntimeException
FEA: ItEr77S16JiraAndTimConnectorContributionIntegration
2013-01-30 12:53:42 +01:00
Manuel Rego Casasnovas
25d508ef46 jira-integration: By default ignore tests that only passes if you have a JIRA server
Some tests only passes if you have a JIRA server installed, as it's not
something mandatory to run LibrePlan, these tests are ignored by default.

FEA: ItEr77S16JiraAndTimConnectorContributionIntegration
2013-01-30 12:22:00 +01:00
Manuel Rego Casasnovas
62ecce6d34 jira-integration: Improve _jiraSyncInfo.zul using vbox
Moreover, the ifs has been moved to an vbox grouping the different components
affected by it.

FEA: ItEr77S16JiraAndTimConnectorContributionIntegration
2013-01-30 11:51:28 +01:00
Manuel Rego Casasnovas
e1bf121b4c jira-integration: Use Collections.unmodifiableList in JiraSyncInfo
In order to simply code of JiraSyncInfo it has been used the method
Collections.unmodifiableList. Moreover, the type of syncFailedReasons has been
changed to List to make it easier.

FEA: ItEr77S16JiraAndTimConnectorContributionIntegration
2013-01-30 11:45:45 +01:00
Manuel Rego Casasnovas
50ab6fee37 jira-integration: Set visibility of attributes in Field class
They are marked as private now.

FEA: ItEr77S16JiraAndTimConnectorContributionIntegration
2013-01-30 11:43:54 +01:00
Manuel Rego Casasnovas
f6ec4e5220 jira-integration: Several refactorizations in JiraRESTClient
* Extracted paths for JIRA REST API to constants.
* Code simplification:
  * Use StringUtils.split
  * Use Collections.singletonList

FEA: ItEr77S16JiraAndTimConnectorContributionIntegration
2013-01-30 11:35:18 +01:00
Manuel Rego Casasnovas
851357d760 jira-integration: Several refactorizations in JiraTimesheetSynchronizer
* Extract save part to a separated method as syncJiraTimesheetWithJiraIssues
  doesn't deal with workReportModel and it could cause misunderstandings.
* Move some parts just needed for newly created objects inside the ifs.
* Use properly EffortDuration to create a new one from seconds.
* Avoid find in another transaction as transaction is already opened.

FEA: ItEr77S16JiraAndTimConnectorContributionIntegration
2013-01-30 11:25:33 +01:00
Manuel Rego Casasnovas
65458cfc9f jira-integration: Avoid whitespace in code use "-" instead
FEA: ItEr77S16JiraAndTimConnectorContributionIntegration
2013-01-30 11:20:37 +01:00
Manuel Rego Casasnovas
d8da496a95 jira-integration: Use the configured TypeOfWorkHours in JiraTimesheetSynchronizer
FEA: ItEr77S16JiraAndTimConnectorContributionIntegration
2013-01-30 11:19:49 +01:00
Manuel Rego Casasnovas
cbc7c3c169 jira-integration: Add checkings to prevent remove or disable type of work hours for JIRA connector
FEA: ItEr77S16JiraAndTimConnectorContributionIntegration
2013-01-30 11:16:50 +01:00
Manuel Rego Casasnovas
ae3b7610f1 jira-integration: Modify bootstraps in order to set JiraConfiguration properly
* Renamed PersonalTimesheetsTypeOfWorkHoursBootstrap to
  ConfigurationTypeOfWorkHoursBootstrapa in order to set up TypeOfWorkHours for
  both personal timesheets and Jira connector.
* Modified ConfigurationBootstrap to ensure that the JiraConfiguration is
  created properly.
* Removed unneeded code in ConfigurationModel.

FEA: ItEr77S16JiraAndTimConnectorContributionIntegration
2013-01-30 11:16:50 +01:00
Manuel Rego Casasnovas
44dca50bc9 jira-integration: Add new field jiraConnectorTypeOfWorkHours in JiraConfiguration
* The new field is added in JiraConfiguration similar to field
Configuration.personalTimesheetsTypeOfWorkHours.
* Added required bits for Hibernate mapping and Liquibase database changes.
* Modified Jira connector configuration UI to include the new field.

FEA: ItEr77S16JiraAndTimConnectorContributionIntegration
2013-01-30 11:16:50 +01:00
Manuel Rego Casasnovas
b68315595a jira-integration: Add messages to the user if default data is not found
Add information for the user if required work report type or type of hours are
not found.

FEA: ItEr77S16JiraAndTimConnectorContributionIntegration
2013-01-30 09:40:38 +01:00
Manuel Rego Casasnovas
31c3247344 jira-integration: Inline startSync method
startSync is private and only used from syncJiraTimesheetWithJiraIssues. So it's
not needed.

FEA: ItEr77S16JiraAndTimConnectorContributionIntegration
2013-01-30 09:36:50 +01:00
Manuel Rego Casasnovas
a7fb973a61 jira-integration: General refactorization JiraOrderElementSynchronizer.updateOrCreateProgressAssignmentAndMeasurement
Different stuff has been fixed in the method:
* Some parts were moved inside the ifs, as they were only needed for newly
  created entities.
* Some unneeded lines were removed:
  * directAdvanceAssignment.setOrderElement as this is already done by
    orderElement.addAdvanceAssignment.
  * advanceMeasurement.setAdvanceAssignment as this is already done by
    directAdvanceAssignment.addAdvanceMeasurements.
* The progress PERCENTAGE is marked as spread to make sure that the task appears
  as finished.

FEA: ItEr77S16JiraAndTimConnectorContributionIntegration
2013-01-30 09:30:54 +01:00
Manuel Rego Casasnovas
cbc3af5973 jira-integration: Change way to calculate estimated hours
Estimated hours are now calculated using the following formula:
* If there're remaining hours:
  Estimated hours = Remaining estimated hours + Logged hours
* Otherwise:
  Estimated hours = Original estimated hours

Moreover the calculation is done now just once, and after the logged hours one.

FEA: ItEr77S16JiraAndTimConnectorContributionIntegration
2013-01-29 22:32:37 +01:00