Commit graph

1594 commits

Author SHA1 Message Date
Oscar Gonzalez Fernandez
bc3583104d Fix performance regression
When opening the `resource allocation modal window` (double-click on a
task), the advanced search was calculating the load of the resources
when it should do it when clicking advanced search button. This leads
to a big delay when opening the `resource allocation modal window` if
there is a moderate amount of data.

Now these calculations are only done when clicking advanced search
button and the `resource allocation modal window` is opened almost
instantly.
2014-04-20 17:41:23 +02:00
Oscar Gonzalez Fernandez
63343353d2 Fix bug #1645
A JavaScript string is being generated quoted by the ' character. If
it finds that character in a string inside the evaled JavaScript it
would terminate the string prematurely, causing syntax errors.
2014-04-14 21:14:01 +02:00
Oscar Gonzalez Fernandez
cbe9ca6c69 Fix bug #1644
When an allocation cannot be done, the error message on the input
disappeared because the rows were re-rendered due to reloadBindings
call. Now this call is avoided and some extracted functionality from
getCurrentRows is called.
2014-04-11 19:22:54 +02:00
Oscar Gonzalez Fernandez
466bcdf585 Remove the listener allResourcesPerDay
It's not strictly necessary since inside the listener is checked that
effortInput is enabled, but for consistency do it the same way as with
effortInput.
2014-04-11 19:22:41 +02:00
Oscar Gonzalez Fernandez
27e5926d8c Be more restrictive when discarding messages
MessagesForUser doesn't discard the messages when changing focus.
2014-04-11 19:22:18 +02:00
Oscar Gonzalez Fernandez
73e0a44c6b Some renamings and documentation added
This would make AllocationRow more understandable.
2014-04-11 19:22:12 +02:00
Oscar Gonzalez Fernandez
d45b801ed2 Fix issue with messages for users
The MessagesForUser component is used for showing information and
error messages to the users. It's designed to disappear once the user
does some action and a minimum of time has passed.

This is done listening to the events being produced in the page. In
previous versions of ZK this was enough to identify user activity, but
in the version currently used, 5.0.11, events not related to user
activity are generated. This causes the messages to disappear without
user action.

With this fix, only when the user clicks on something, or changes the
value of some input the shown message is cleared.
2014-04-10 01:29:21 +02:00
Oscar Gonzalez Fernandez
5530184f8a Escape ' characters used along with positional parameters
The command `find -ipath "*src*.po"|xargs sed -ie "/msgstr.*{[0-9]}/
s/\([^']\)'\([^']\)/\1''\2/g"` was used to do the fix.
2014-04-02 20:05:21 +02:00
Oscar Gonzalez Fernandez
f1a7c0370a Fix bug #1643
Java's Gettext Commons,
http://xnap-commons.sourceforge.net/gettext-commons/, uses
java.text.MessageFormat for doing the parameter substitution.
MessageFormat interprets ' as an escaping character. In order to
introduce ', you have to escape it, i.e., you have to type '' instead.
Otherwise posterior positional parameters like {0} aren't interpreted.
2014-04-02 18:49:35 +02:00
Oscar Gonzalez Fernandez
70a8013eb9 Fix bug #1642
When checking the condition
`isOnlyChildAndParentAlreadyInUseByHoursOrExpenses` the parent might
be a new object. In that case the check if false and no further
querying must be done in the parent.
2014-04-01 18:50:49 +02:00
Jeroen Baten
e4b2f5783d Batch of changed english strings, including in po files 2014-03-26 12:36:00 +01:00
Oscar Gonzalez Fernandez
1820f98488 Remove dead code
The removed code is never executed. editWindow is always not null at
that moment.
2014-03-18 16:27:53 +01:00
miciele Ghiorghis
e3bbe83aae filter-on-projectname: textbox to enter projectname is added 2014-03-17 23:04:09 +01:00
miciele Ghiorghis
ee415e2dca filter-on-projectname: modified to use project name as filter criteria 2014-03-17 23:04:09 +01:00
miciele Ghiorghis
fb98fa0a4f filter-on-projectname: modified to support filter on part of project name 2014-03-17 23:04:09 +01:00
miciele Ghiorghis
917110efec filter-on-projectname: acceptFilerName method added to accept filter on part of projectname 2014-03-17 23:04:09 +01:00
miciele Ghiorghis
6a6110ab7a filter-on-projectname: acceptFilerName method added to accept filter on part of projectname 2014-03-17 23:04:09 +01:00
miciele Ghiorghis
e5fdc5ea47 filter-on-projectname: modified to support filter on part of project name 2014-03-17 23:04:09 +01:00
miciele Ghiorghis
20eb7d50b1 filter-on-projectname: new methods added to read and write filter name attribute 2014-03-17 23:04:09 +01:00
Oscar Gonzalez Fernandez
e80647ee8c Remove unused method 2014-03-17 22:47:49 +01:00
Oscar Gonzalez Fernandez
c93a1399f3 Use parameters instead of concatenating
The structure of the tooltip can change depending on the language.
Concatenating strings hardwires it to the English language. Using
parameters instead.
2014-03-17 22:44:44 +01:00
miciele Ghiorghis
3f524129c7 project-margins-and-status: new styles added for project status 2014-03-10 18:39:00 +01:00
miciele Ghiorghis
297286732e project-margins-and-status: input components added for hours and budget margin 2014-03-10 18:39:00 +01:00
miciele Ghiorghis
ef9d021b3f project-margins-and-status: implementation of get Project's hours and budget status and tooltipText for the project status
extended with the implementation of the ITaskFundamentalProperties:
- getProjectHoursStatus()
- getProjectBudgetStatus()
- getTooltipTextForProjectHoursStatus()
- getTooltipTextForProjectBudgetStatus()
2014-03-10 18:39:00 +01:00
Oscar Gonzalez Fernandez
7e773b7eb1 Fix test failure
Now all tests should pass. The error was introduced in the commit
4baa93d790.
2013-11-26 19:52:47 +01:00
Lorenzo Tilve Álvaro
0c33a9431c Undo expense column recalculation on budget changes
The patch "Refreshed calculated expense column on hours or budget changes"
on commit 8c2c7996a2 can cause
compilation problems depeding on the JAVA version installed, so it's
reverted till it gets avoided.

FEA: ItEr77S17AutomaticBudgeting
2013-07-31 19:57:45 +02:00
Lorenzo Tilve Álvaro
a8eefaaa29 Modified automatic budget cell calculations and rearranged report
The manually introduced budget cell will be representing the total
amount for the budget on that item, and the expenses cell will
show the difference between that total and the resources costs
for the task hours and required criteria.

FEA: ItEr77S17AutomaticBudgeting
2013-07-31 19:57:33 +02:00
Lorenzo Tilve Álvaro
8c2c7996a2 Refreshed calculated expense column on hours or budget changes
FEA: ItEr77S17AutomaticBudgeting
2013-07-14 22:03:53 +02:00
Lorenzo Tilve Álvaro
50a6f91b1a Modified calculations for the total column when automatic budgeting enabled
The budget cell will represent the total available budget, and the calculated
read-only total, will be the result of substracting the consumed budget due
to the hours and cost categories of the assinged task criteria.

FEA: ItEr77S17AutomaticBudgeting
2013-07-05 02:22:45 +02:00
Lorenzo Tilve Álvaro
dd4d117fa1 Step 1 2013-07-03 11:50:05 +02:00
Oscar Gonzalez Fernandez
17a49b1d9d Use utility method 2013-06-22 11:27:15 +02:00
Oscar Gonzalez Fernandez
4109281e2f Remove use of class introduced in JDK 1.7
Otherwise it wouldn't compile in the integration server. The
possibility of increasing Java version requirement to JDK 7 should be
considered.
2013-06-22 11:26:44 +02:00
Oscar Gonzalez Fernandez
df0a6d1502 Fix potential problem
The capture url could be the same if it's generated in the same
second.
2013-06-21 14:51:57 +02:00
Oscar Gonzalez Fernandez
98bcf3decd Don't use the same display number always
Otherwise the Xvfb server could fail if another printing request
overlaps. They get different display numbers now.
2013-06-21 14:51:57 +02:00
Oscar Gonzalez Fernandez
e9d1463a28 Show output from printing process
It helps to debug any problem that could occur when executing the
processes.
2013-06-21 14:51:57 +02:00
Oscar Gonzalez Fernandez
05bd5b2da0 Remove unused constant 2013-06-21 14:51:56 +02:00
Oscar Gonzalez Fernandez
64b6781895 Move helper methods closer 2013-06-21 14:51:56 +02:00
Oscar Gonzalez Fernandez
f86c9d8aa0 Refactor to the creation of css file
Error handling improved, removed the call to System.exit.
2013-06-21 14:51:56 +02:00
Oscar Gonzalez Fernandez
dc639f61a3 Encode correctly http parameters
If the value of the parameters had URI reserved characters, they must
be encoded. URI builder handles that.
2013-06-21 14:51:56 +02:00
Oscar Gonzalez Fernandez
f14de444ac Introduce parameter object
Introduce parameter object to simplify the intent of the code.
2013-06-21 14:51:56 +02:00
Oscar Gonzalez Fernandez
9576e135ad Use ProcessBuilder to construct program calls
Avoid potential remote code execution through the `parameters`
parameter. They were concatenated to the capture command String
directly, which could lead to the injection of malicious code.

Currently the problem isn't exposed because the potential attacker
can't control the contents of the `parameters` map, since their
contents are chosen from a limited set of values.
2013-06-21 14:51:56 +02:00
Lorenzo Tilve Álvaro
b512f75bfc Disabled loading of HourCosts associated to Criterion CostCategory
FEA: ItEr77S17AutomaticBudgeting

As a method has been added to HourCostDAO to provide the PricePerHour associated
to a category, for an specific WorkHourType, the loading and attachment of
these objects is not longer needed here.
2013-06-19 13:41:36 +02:00
Lorenzo Tilve Álvaro
902ad00b80 Bug #1619: Adding elements from template to the WBS was not showing the new nodes
FEA: ItEr77S04BugFixing
2013-06-19 13:41:36 +02:00
Lorenzo Tilve Álvaro
b30fbb28a2 Parametrized use of resources budget column
FEA: ItEr77S17AutomaticBudgeting
2013-06-19 13:41:21 +02:00
Lorenzo Tilve Álvaro
2ccb291570 Modified transactional wrapper to avoid duplicating session
FEA: ItEr77S17AutomaticBudgeting
2013-06-19 12:38:03 +02:00
Lorenzo Tilve Álvaro
25d359d653 Fixed NPE when attaching criterion without costCategories
FEA: ItEr77S17AutomaticBudgeting
2013-06-19 12:35:16 +02:00
Lorenzo Tilve Álvaro
43e14d8dae Added condition to show resources budget column
FEA: ItEr77S17AutomaticBudgeting
2013-06-19 12:34:31 +02:00
Lorenzo Tilve Álvaro
cd63d13805 Attached onBlur event to remove CostCategory after clearing the autocomplete
FEA: ItEr77S17AutomaticBudgeting
2013-06-14 10:48:51 +02:00
Lorenzo Tilve Álvaro
a10f37d390 Added restriction to avoid deletion of costCategories assigned to criterion
FEA: ItEr77S17AutomaticBudgeting
2013-06-14 10:10:17 +02:00
Lorenzo Tilve Álvaro
6bc887739d Added grouping headers to new report with all columns
FEA: ItEr77S17AutomaticBudgeting
2013-06-13 18:12:22 +02:00